Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created coherentstate! for inplace operations #245

Merged

Conversation

atombear
Copy link
Contributor

closes #244

@atombear atombear force-pushed the feature/coherent_state_inplace_naming branch from a6f5897 to 994afcd Compare March 20, 2019 23:19
@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 96.695% when pulling 994afcd on atombear:feature/coherent_state_inplace_naming into 07db21f on qojulia:master.

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #245 into master will increase coverage by 3.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage    93.4%   96.69%   +3.28%     
==========================================
  Files          36       36              
  Lines        2973     2874      -99     
==========================================
+ Hits         2777     2779       +2     
+ Misses        196       95     -101
Impacted Files Coverage Δ
src/QuantumOptics.jl 100% <ø> (ø) ⬆️
src/fock.jl 100% <100%> (ø) ⬆️
src/phasespace.jl 100% <100%> (+4.06%) ⬆️
src/operators_lazysum.jl 89.74% <0%> (-7.48%) ⬇️
src/operators_sparse.jl 85.54% <0%> (-2.12%) ⬇️
src/bases.jl 94.66% <0%> (-1.28%) ⬇️
src/manybody.jl 100% <0%> (+0.9%) ⬆️
src/operators_lazytensor.jl 100% <0%> (+1.12%) ⬆️
src/stochastic_schroedinger.jl 100% <0%> (+2.17%) ⬆️
src/superoperators.jl 80.85% <0%> (+2.5%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07db21f...994afcd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #245 into master will increase coverage by 3.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage    93.4%   96.69%   +3.28%     
==========================================
  Files          36       36              
  Lines        2973     2874      -99     
==========================================
+ Hits         2777     2779       +2     
+ Misses        196       95     -101
Impacted Files Coverage Δ
src/QuantumOptics.jl 100% <ø> (ø) ⬆️
src/fock.jl 100% <100%> (ø) ⬆️
src/phasespace.jl 100% <100%> (+4.06%) ⬆️
src/operators_lazysum.jl 89.74% <0%> (-7.48%) ⬇️
src/operators_sparse.jl 85.54% <0%> (-2.12%) ⬇️
src/bases.jl 94.66% <0%> (-1.28%) ⬇️
src/manybody.jl 100% <0%> (+0.9%) ⬆️
src/operators_lazytensor.jl 100% <0%> (+1.12%) ⬆️
src/stochastic_schroedinger.jl 100% <0%> (+2.17%) ⬆️
src/superoperators.jl 80.85% <0%> (+2.5%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07db21f...994afcd. Read the comment docs.

@david-pl david-pl merged commit 8b370d9 into qojulia:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coherent_state in-place function should be named with an exclamation point
3 participants