Merge pull request #10027 from hkollmann/fix_compiler_warnings

fix some compiler warnings
qooxdoo · Aug 28, 2020 · 2d4b641 · 2d4b641
2 parents cbbae1a + b8ad391
commit 2d4b641
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/framework/source/class/qx/bom/History.js b/framework/source/class/qx/bom/History.js
@@ -328,7 +328,7 @@ qx.Class.define("qx.bom.History",
      * Simulates a back button click.
      */
      navigateBack : function() {
-       qx.event.Timer.once(function() {history.back();}, this, 100);
+       qx.event.Timer.once(function() {window.history.back();}, this, 100);
      },
 
 
@@ -337,7 +337,7 @@ qx.Class.define("qx.bom.History",
      * Simulates a forward button click.
      */
      navigateForward : function() {
-       qx.event.Timer.once(function() {history.forward();}, this, 100);
+       qx.event.Timer.once(function() {window.history.forward();}, this, 100);
      },
 
 

diff --git a/framework/source/class/qx/bom/client/Pdfjs.js b/framework/source/class/qx/bom/client/Pdfjs.js
@@ -51,6 +51,7 @@
  *
  * @internal
  * @asset(qx/static/empty.pdf)
+ * @ignore($.browser)
  */
 qx.Bootstrap.define("qx.bom.client.Pdfjs",
 {

diff --git a/framework/source/class/qx/dev/unit/Sinon.js b/framework/source/class/qx/dev/unit/Sinon.js
@@ -3998,9 +3998,11 @@ if (typeof sinon == "undefined") {
     });
 
     // Borrowed from JSpec
+    // @ignore(DOMParser)
+    // @ignore(ActiveXObject)
     FakeXMLHttpRequest.parseXML = function parseXML(text) {
         var xmlDoc;
-
+ 
         if (typeof DOMParser != "undefined") {
             var parser = new DOMParser();
             xmlDoc = parser.parseFromString(text, "text/xml");

diff --git a/framework/source/class/qx/ui/root/Application.js b/framework/source/class/qx/ui/root/Application.js
@@ -129,7 +129,7 @@ qx.Class.define("qx.ui.root.Application",
         // contain a body tag explicitly. Unfortunately, it cannot be added
         // here dynamically.
         if (!doc.body) {
-          alert("The application could not be started due to a missing body tag in the HTML file!");
+          window.alert("The application could not be started due to a missing body tag in the HTML file!");
         }
       }