disable optional output formatter #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i like this PR but it's a BC, so i am not 100% sure. |
|
We still have no 1.0 release and printing following disclaimer: |
DavidBadura
approved these changes
Oct 17, 2018
|
Semver is allowing us having breaking changes in a zero-mayor-version. If there no others concerns when BC it should be merged. The documentation may have to be updated and changelog/upgrade guide could added. |
|
from my point it's ok. feel free to merge :) |
smoench
force-pushed
the
disable-optional-output-formatter
branch
from
02cbdbc
to
9a58602
Compare
smoench
force-pushed
the
disable-optional-output-formatter
branch
from
9a58602
to
e795ca2
Compare
|
I added another/more reliable way to enable/disable formatters by default. Reviews are welcome :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphiz is an optional dependency and JUnit requires
ext-dom