Report yaml syntax errors in more detail #662
Conversation
| $exception->getMessage() | ||
| )); | ||
| } | ||
|
|
||
| public static function fromFilename(string $filename): self |
There was a problem hiding this comment.
Is this method then still in use?
There was a problem hiding this comment.
it seems it is only used from within a test. not sure it make sense to delete it though for BC reasons. marking as deprecated could be an option?
There was a problem hiding this comment.
There is no BC consideration if there is no public user-facing API, based on the usage of this tool. So from that perspective, it should be fine to delete it. The fact that it is used only for testing is problematic and IMHO symptom of bad design. If you are able to rewrite the test to not use it, it is IMHO safe to delete.
There was a problem hiding this comment.
ok, removed the method and adjusted the test-case for it to actually test the newly introduced method
fixes #661
more details in yaml syntax errors