-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report yaml syntax errors in more detail #662
Conversation
$exception->getMessage() | ||
)); | ||
} | ||
|
||
public static function fromFilename(string $filename): self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this method then still in use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems it is only used from within a test. not sure it make sense to delete it though for BC reasons. marking as deprecated could be an option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no BC consideration if there is no public user-facing API, based on the usage of this tool. So from that perspective, it should be fine to delete it. The fact that it is used only for testing is problematic and IMHO symptom of bad design. If you are able to rewrite the test to not use it, it is IMHO safe to delete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, removed the method and adjusted the test-case for it to actually test the newly introduced method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @staabm.
fixes #661
more details in yaml syntax errors