Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to php 8.1 #935

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Update to php 8.1 #935

merged 1 commit into from
Aug 12, 2022

Conversation

patrickkusebauch
Copy link
Collaborator

@patrickkusebauch patrickkusebauch commented Jul 28, 2022 •
edited
Loading

Closes #906

I suspect that workflows will fail because GitHub will use the old workflow and not the applied changes in this PR. OK, it seems that I was wrong.

dbrumann
dbrumann approved these changes Jul 29, 2022
View reviewed changes
Copy link
Collaborator

@dbrumann dbrumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I want to merge #936 and #932 before merging this. After they are released, I will merge this right away.

@dbrumann dbrumann merged commit c709f97 into qossmic:main Aug 12, 2022
@patrickkusebauch patrickkusebauch deleted the feature/php_version branch August 12, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrumann dbrumann dbrumann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for PHP 7.4
2 participants
@patrickkusebauch @dbrumann