Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort composer packages #97

Merged
merged 1 commit into from
May 17, 2016

Conversation

amansilla
Copy link

Just alphabetically sort the composer packages to keep it more readable.

If you wanna keep your composer dependencies alphabetically
sorted, add the composer dependencies in the following way:

php composer.phar require vendor/package --sort-packages
@@ -4,8 +4,8 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file",
"This file is @generated automatically"
],
"hash": "ebe771ebefde29ab37094e27b1a8383d",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't change, or @amansilla ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slde-flash I guess yes, since the hash property hashes the full composer.json file and it has changed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slde-flash After a bit of research, I definitely can say the composer.lock is right to be changed, since as previously said that hash attribute is the hash of the full composer.json, so any change in the composer.json file should be followed by changes in the composer.lock. That's something we missed for example in #95. If there is no new package added to the require or require-dev which would force an update of the composer.lock, then it would be necessary to update the composer.lock file executing composer update --lock in order to update the composer.lock.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarification :)

@slde-flash slde-flash merged commit fc54fa1 into qossmic:master May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants