Add tests for self update command #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amansilla
changed the title
amansilla
force-pushed
the
self-update-command-tests
branch
from
271b1f0
to
41e8a8a
Compare
| */ | ||
| public function testUpdateSuccess($isPharOutdated) | ||
| { | ||
| if ($isPharOutdated) { |
There was a problem hiding this comment.
just use $this->updater->update()->willReturn($isPharOutdated);
amansilla
force-pushed
the
self-update-command-tests
branch
from
41e8a8a
to
8594f36
Compare
|
@slde-flash I fixed the code following your instructions, so I guess now is ready to be merged. |
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests add some tests for the self-update command.
The command itself was added as well in order to allow testing but there is a dedicated pull request for that, see #84.