fix(spinner): direct spinner to stderr instead of stdout #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise weird spinner output is printed to stuff that get's piped from the command line
dustmop
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Using stderr instead of stdout is an improvement, but not the ideal solution. We should instead detect the type of pipe, and only output if we know we're writing to a tty or whatever. Doing so is OS specific, however. Could you add a TODO like "//TODO: Detect output pipe and only write spinner if it's a tty"
|
Did you one better and opened an issue 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise weird spinner output is printed to stuff that get's piped from the command line