time: apply remarks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fantastic! Thank you so much @essobedo. I've given you write access to this repo and will merge this PR as-is. Thank you so much for your help, and welcome aboard! |
|
@essobedo moving forward please feel free to take over my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @b5
Here is a small contribution to help you finishing implementing google#19. @srebhan asked me to help you, here I am 😄
Hoping it is helpful
NB 1: If my help is useful and there are other things to do, please grant me access to your branch to allow me to commit directly there.
NB2: For https://github.com/google/starlark-go/pull/327/files#r551016536, you will need to rebase with master as it is a new feature