Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(qri): use string value instead of datastore.Key #29

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Conversation

b5
Copy link
Member

@b5 b5 commented Jan 27, 2019

depends on qri-io/cafs#22. depends on qri-io/dataset#168.

@b5 b5 added the refactor label Jan 27, 2019
@b5 b5 self-assigned this Jan 27, 2019
@ghost ghost added the in progress label Jan 27, 2019
b5 added a commit to qri-io/qri that referenced this pull request Jan 27, 2019
implements changes made in qri-io/cafs#22. When interacting with a cafs.Filestore, use strings instead of datastore.Key

depends on qri-io/cafs#22. depends on qri-io/dataset#168. depends on qri-io/startf#29
Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@b5
Copy link
Member Author

b5 commented Jan 28, 2019

merging w CI failing b/c of a crossed-dependency with qri-io/qri#677

@b5 b5 merged commit 96c9cc4 into master Jan 28, 2019
@b5 b5 deleted the cafs_refactor branch January 28, 2019 19:58
@ghost ghost removed the in progress label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants