Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4121][ADD] stock_picking_validate_jobcan_wf #83

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Jun 21, 2024

@AungKoKoLin1997
Copy link
Contributor Author

I can't decide we should display the ValidationError or keep current design that is displayed warning message in related picking.

Downside of current approach:

  • When we validate batch records and some pickings are not validated because of jobcan workflow is not completed, the ValidationError is not raised and user may think all are successfully validated.

Downside of displaying ValidationError:

  • When user validates the pickings and ValidationError will be raised. So, the picking that should be successful can't be validated. Then, when user opens the record of picking that is failed because of jobcan workflow, user can't know he didn't validate or failed for some reason. So, he have to click validate button again.

@yostashiro yostashiro force-pushed the 4121-add-stock_picking_validate_jobcan branch from 675428a to 1245efa Compare July 3, 2024 12:59
@yostashiro yostashiro force-pushed the 4121-add-stock_picking_validate_jobcan branch from 1245efa to 6363f06 Compare July 3, 2024 13:11
@yostashiro yostashiro changed the title [4121][ADD] stock_picking_validate_jobcan [4121][ADD] stock_picking_validate_jobcan_wf Jul 3, 2024
@yostashiro
Copy link
Member

I can't decide we should display the ValidationError or keep current design that is displayed warning message in related picking.

Downside of current approach:

  • When we validate batch records and some pickings are not validated because of jobcan workflow is not completed, the ValidationError is not raised and user may think all are successfully validated.

Downside of displaying ValidationError:

  • When user validates the pickings and ValidationError will be raised. So, the picking that should be successful can't be validated. Then, when user opens the record of picking that is failed because of jobcan workflow, user can't know he didn't validate or failed for some reason. So, he have to click validate button again.

Took the approach of showing UserError in my update. There is almost no benefit in partially processing pickings in batch validation for the added complexity, when the batch validation is triggered by an operator (not by some automated process).

@yostashiro yostashiro merged commit 3720a67 into 16.0 Jul 8, 2024
2 checks passed
@AungKoKoLin1997 AungKoKoLin1997 deleted the 4121-add-stock_picking_validate_jobcan branch October 31, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants