Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not work with minitest 5.16.X #93

Closed
zw963 opened this issue Oct 5, 2022 · 15 comments
Closed

Not work with minitest 5.16.X #93

zw963 opened this issue Oct 5, 2022 · 15 comments

Comments

@zw963
Copy link

zw963 commented Oct 5, 2022

/home/common/.rvm/gems/ruby-3.1.2@pryx/gems/minitest-5.16.0/lib/minitest/test.rb:70:in `srand': no implicit conversion of nil into Integer (TypeError)
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/minitest-5.16.0/lib/minitest/test.rb:70:in `runnable_methods'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/runners/minitest_5.rb:15:in `test_methods'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:90:in `block in suites'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:88:in `each'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:88:in `each_with_object'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:88:in `suites'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:61:in `tests'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/executor.rb:15:in `execute'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m/runner.rb:17:in `run'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/lib/m.rb:13:in `run'
        from /home/common/.rvm/gems/ruby-3.1.2@pryx/gems/m-1.6.0/bin/m:4:in `<top (required)>'
        from /home/zw963/.rvm/gems/ruby-3.1.2@pryx/bin/m:25:in `load'
        from /home/zw963/.rvm/gems/ruby-3.1.2@pryx/bin/m:25:in `<main>'
        from /home/zw963/.rvm/rubies/ruby-3.1.2/bin/ruby_executable_hooks:22:in `eval'
        from /home/zw963/.rvm/rubies/ruby-3.1.2/bin/ruby_executable_hooks:22:in `<main>'
rake aborted!
Command failed with status (1): [m test/pryx/pryx_test.rb...]
/home/common/Project/pryx/Rakefile:4:in `block in <top (required)>'
Tasks: TOP => default
(See full trace by running task with --trace)

The last support version is 5.15.0

@felixonmars
Copy link
Contributor

Fixed by #92

@zw963
Copy link
Author

zw963 commented Oct 20, 2022

@qrush , can we release a new version?

@zw963
Copy link
Author

zw963 commented Oct 20, 2022

Fixed by #92

谢谢,肥猫,最近在看 Ruby 吗?不如连 Crystal 一起看看吧。

@qrush
Copy link
Owner

qrush commented Oct 20, 2022

@gi any chance you're up for pushing a new version here? 😅 🙏🏼

@zedtux
Copy link

zedtux commented Oct 21, 2022

Yes, please, release a new version 🙏

@merof-code
Copy link

I have no idea why, but no matter what, VS Code marketplace shows that 0.9.1 exists, but you cannot download it
windows with wsl2 Ubuntu 22.04.
While all that, I just downgraded minitest version
image

@searls
Copy link
Collaborator

searls commented Nov 18, 2022

@qrush / @gi -- if you're open to it, I'm willing to help maintain m and to get releases like this out the door. I had been incorrectly assuming m was unmaintained and thinking of building something inspired by it but it seems like it's still working (except I'm blocked by this issue)

@qrush
Copy link
Owner

qrush commented Nov 18, 2022

@searls just invited you. :shipit:

@searls
Copy link
Collaborator

searls commented Nov 18, 2022

@qrush thanks! I can't get the tests to pass without updating bundler (which means I should commit back to the repo). Could I have commit bit too?

@searls
Copy link
Collaborator

searls commented Nov 19, 2022

Landed the change in 1.6.1. CI is not happy about it, but all tests passed locally at least.

More broadly, @qrush, if you'd like to talk about ongoing maintenance and feature development for the gem, I've got some ideas about contributing!

@searls searls closed this as completed Nov 19, 2022
@qrush
Copy link
Owner

qrush commented Nov 19, 2022 via email

@jrochkind
Copy link

Just found this ticket after having this problem -- would love to see a release. Any chance?

@searls
Copy link
Collaborator

searls commented Dec 13, 2022

@jrochkind yes this was released in m@1.6.1

@jrochkind
Copy link

jrochkind commented Dec 13, 2022

Oh, thanks! And thanks for quick response!

What had I done? Ah, I was just trying minitest in a new project today, and copy-pasted from the README gem 'm', '~> 1.5.0', so that kept me from using the up-to-date 1.6.1, oops! Thanks!

You may want to replace README copy-paste line with gem 'm', '~> 1.6'? Not only updating to latest minor version, but if it gets out of date again like that, with only two version components, if someone copies-pastes it will still allow 1.7, 1.8, 1.10, etc. Whereas ~> 1.5.0 only allows 1.5.x.

I think I'm learning to never copy-paste version numbers from README, this is the second time this month it's bitten me!

@searls
Copy link
Collaborator

searls commented Dec 13, 2022

Thanks for catching this. I just removed the version pins from the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants