Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworks eth send raw transaction flow with qtum utxos #38

Conversation

IntegralTeam
Copy link

Revisions Ethereum send raw transaction method:

  • pkg/eth/rpc_types.go: add SendRawTransactionRequest and SendRawTransactionResponse types;
  • pkg/qtum/rpc_types.go: add SendRawTransactionRequest and SendRawTransactionResposne types;
  • pkg/qtum/method.go: add Method.SendRawTransaction();
  • pkg/transformer/eth_sendRawTransaction.go: revision ProxyETHSendRawTransaction.Request().Implements get qtum UTXOs RPC proxy:
  • pkg/eth/rpc_types.go: add GetUTXOsRequest{};
  • pkg/transformer/util.go: add convertETHAddress() and convertQtumAddress();
  • pkg/qtum/rpc_types.go: actualize ListUnspentRequest{}, ListUnspentResponse{}; add ListUnspentQueryOptions{};
  • pkg/transformer/qtum_getUTXOs.go: add ProxyQTUMGetUTXOs{};
  • pkg/transformer/transformer.go: add ProxyQTUMGetUTXOs{} to DefaultProxies().

qtumChain string
ethAddress string
qtumAddress string
}{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get a couple more tests in here. see these notes for some good test cases that I would want to ensure converted. https://github.com/hayeah/openzeppelin-solidity/blob/qtum/QTUM-NOTES.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The issue is solved. Please, see commit hash ac69fa5

@IntegralTeam IntegralTeam force-pushed the reworks-eth-send-raw-transaction-flow-with-qtum-utxos branch from ff6c980 to ac69fa5 Compare February 19, 2021 09:41
@VoR0220 VoR0220 merged commit 0ad1411 into qtumproject:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants