fix bug in eth_subscribe with 0x prefix and bug in unit test for agen… #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR implement 2 fixes related to bugs when subscribing to events via web3 and the corresponding unit test
1. Fix bug in eth_subscribe with "0x" prefix in contract address
Bug description
A web3 script that subscribes to an ethereum event sends contract address with "0x" prefix, but qtum expects contract address without "0x":
Bug fix
In
notifier/subscription.go
:2. Fix bug in unit tests for websocket subscription
Bug description
After implementing fix described above, unit tests fail for web sockets subscription
Bug fix
The mocked qtum response when testing event subscription should use a contract address without "0x" prefix
internal/tests_common.go