patch(fix): hook callback standards.

- pre-* hooks to be called with same args as original method.
- post-* hooks to be called with same returns type of original method.

Author: rash805115

packages/octo/src/decorators/enable-hook.decorator.ts

@@ -1,11 +1,11 @@
 import { Constructable } from '../app.type.js';
 import { AHook } from '../functions/hook/hook.abstract.js';
 
-export function EnableHook<T>(hook: {
+export function EnableHook(hook: {
   new (): AHook;
-  registrar: (constructor: Constructable<unknown>, propertyKey: string, descriptor: TypedPropertyDescriptor<T>) => void;
-}): (target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<T>) => void {
-  return function (target: any, propertyKey: string, descriptor: TypedPropertyDescriptor<T>) {
+  registrar: (constructor: Constructable<unknown>, propertyKey: string, descriptor: PropertyDescriptor) => void;
+}): (target: any, propertyKey: string, descriptor: PropertyDescriptor) => void {
+  return function (target: any, propertyKey: string, descriptor: PropertyDescriptor) {
     hook.registrar(target.constructor, propertyKey, descriptor);
   };
 }

packages/octo/src/functions/hook/post-model-action-handle.hook.ts

@@ -3,7 +3,6 @@ import { IModelAction } from '../../models/model-action.interface.js';
 import { AHook } from './hook.abstract.js';
 
 export type PostModelActionCallback = (output: ActionOutputs) => Promise<ActionOutputs>;
-type PostModelActionMethodSignature = (...args: any[]) => Promise<ActionOutputs>;
 
 export class PostModelActionHandleHook extends AHook {
   private static readonly callbacks: { [key: string]: PostModelActionCallback[] } = {};
@@ -23,7 +22,7 @@ export class PostModelActionHandleHook extends AHook {
   static override registrar(
     constructor: Constructable<unknown>,
     propertyKey: string,
-    descriptor: TypedPropertyDescriptor<PostModelActionMethodSignature>,
+    descriptor: PropertyDescriptor,
   ): void {
     if (!this.isInstanceOfModelAction(constructor.prototype)) {
       throw new Error('PostModelActionHandleHook can only be used with ModelAction!');

packages/octo/src/functions/hook/pre-commit-handle.hook.ts

@@ -1,10 +1,7 @@
 import { Constructable } from '../../app.type.js';
-import { App } from '../../models/app/app.model.js';
-import { DiffMetadata } from '../diff/diff-metadata.js';
 import { AHook } from './hook.abstract.js';
 
-export type PreCommitCallback = (modelTransaction: DiffMetadata[][]) => Promise<void>;
-type PreCommitMethodSignature = (app: App, modelTransaction: DiffMetadata[][]) => Promise<void>;
+export type PreCommitCallback = (...args: any[]) => Promise<void>;
 
 export class PreCommitHandleHook extends AHook {
   private static readonly callbacks: PreCommitCallback[] = [];
@@ -17,18 +14,18 @@ export class PreCommitHandleHook extends AHook {
   static override registrar(
     constructor: Constructable<unknown>,
     propertyKey: string,
-    descriptor: TypedPropertyDescriptor<PreCommitMethodSignature>,
+    descriptor: PropertyDescriptor,
   ): void {
     const originalMethod = descriptor.value;
     const self = this; // eslint-disable-line @typescript-eslint/no-this-alias
 
     // `self` here references PreCommitHandleHook, vs `this` references the original method.
-    descriptor.value = async function (...args: [app: App, modelTransaction: DiffMetadata[][]]): Promise<void> {
+    descriptor.value = async function (...args: any[]): Promise<any> {
       for (const callback of self.callbacks) {
-        await callback(args[1]);
+        await callback.apply(this, args);
       }
 
-      await originalMethod!.apply(this, args);
+      return await originalMethod!.apply(this, args);
     };
   }
 }