patch(fix): octo-aws-cdk resource diffs must not call super().

- Calling super() could lead to issues where DELETE and UPDATE diffs are generated together.

Author: rash805115

packages/octo-aws-cdk/src/resources/iam/iam-role.resource.ts

@@ -16,7 +16,16 @@ export class IamRole extends AResource<IamRole> {
   }
 
   override async diff(previous?: IamRole): Promise<Diff[]> {
-    const diffs = await super.diff(previous);
+    const diffs: Diff[] = [];
+
+    if (this.isMarkedDeleted()) {
+      diffs.push(new Diff(previous || this, DiffAction.DELETE, 'resourceId', this.resourceId));
+      return diffs;
+    }
+
+    if (!previous) {
+      diffs.push(new Diff(this, DiffAction.ADD, 'resourceId', this.resourceId));
+    }
 
     if (this.policyDiff && Object.keys(this.policyDiff).length > 0) {
       for (const key of Object.keys(this.policyDiff)) {

packages/octo-aws-cdk/src/resources/iam/iam-user.resource.ts

@@ -16,7 +16,16 @@ export class IamUser extends AResource<IamUser> {
   }
 
   override async diff(previous?: IamUser): Promise<Diff[]> {
-    const diffs = await super.diff(previous);
+    const diffs: Diff[] = [];
+
+    if (this.isMarkedDeleted()) {
+      diffs.push(new Diff(previous || this, DiffAction.DELETE, 'resourceId', this.resourceId));
+      return diffs;
+    }
+
+    if (!previous) {
+      diffs.push(new Diff(this, DiffAction.ADD, 'resourceId', this.resourceId));
+    }
 
     if (this.policyDiff && Object.keys(this.policyDiff).length > 0) {
       for (const key of Object.keys(this.policyDiff)) {

packages/octo-aws-cdk/src/resources/s3/storage/s3-storage.resource.ts

@@ -12,7 +12,16 @@ export class S3Storage extends AResource<S3Storage> {
   }
 
   override async diff(previous?: S3Storage): Promise<Diff[]> {
-    const diffs = await super.diff(previous);
+    const diffs: Diff[] = [];
+
+    if (this.isMarkedDeleted()) {
+      diffs.push(new Diff(previous || this, DiffAction.DELETE, 'resourceId', this.resourceId));
+      return diffs;
+    }
+
+    if (!previous) {
+      diffs.push(new Diff(this, DiffAction.ADD, 'resourceId', this.resourceId));
+    }
 
     if (this.manifestDiff && Object.keys(this.manifestDiff).length > 0) {
       diffs.push(new Diff(this, DiffAction.UPDATE, 'update-source-paths', this.manifestDiff));

packages/octo-aws-cdk/src/resources/s3/website/s3-website.resource.ts

@@ -12,7 +12,16 @@ export class S3Website extends AResource<S3Website> {
   }
 
   override async diff(previous?: S3Website): Promise<Diff[]> {
-    const diffs = await super.diff(previous);
+    const diffs: Diff[] = [];
+
+    if (this.isMarkedDeleted()) {
+      diffs.push(new Diff(previous || this, DiffAction.DELETE, 'resourceId', this.resourceId));
+      return diffs;
+    }
+
+    if (!previous) {
+      diffs.push(new Diff(this, DiffAction.ADD, 'resourceId', this.resourceId));
+    }
 
     if (this.manifestDiff && Object.keys(this.manifestDiff).length > 0) {
       diffs.push(new Diff(this, DiffAction.UPDATE, 'update-source-paths', this.manifestDiff));