-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inequality comparison issue using <> #1347
Conversation
We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact. |
@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel. A member of the Team first needs to authorize it. |
We require contributors to sign our Contributor License Agreement, and we don"t have one on file for you. In order for us to review and merge your code, please contact our team at https://www.quadratichq.com/contact. |
I checked and there are tests already associated with this feature, so not sure why they were passing 🤔 I validate the UI and confirmed the issue is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @AyushAgrawal-A2!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1347 +/- ##
==========================================
+ Coverage 89.24% 89.34% +0.10%
==========================================
Files 160 160
Lines 26552 26425 -127
==========================================
- Hits 23696 23610 -86
+ Misses 2856 2815 -41 ☔ View full report in Codecov by Sentry. |
closes #1328
Changes:
<>
as well