-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make getCells synchronous #1450
feat: make getCells synchronous #1450
Conversation
@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel. A member of the Team first needs to authorize it. |
4da4c9c
to
f81adf8
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ad6fe24
to
b259d21
Compare
f167f1f
to
d1583c7
Compare
f94d501
to
0b14286
Compare
This works great. Outside of the necessary server changes, is there anything else that makes this a POC and not ready for review? We'll also need this ported to JS so we can remove the await requirement there as well. |
@davidfig |
Awesome. Works wonderfully. |
Please resolve conflicts (hopefully last one) |
@davidfig |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
- Coverage 90.92% 89.78% -1.14%
==========================================
Files 180 185 +5
Lines 34169 34763 +594
==========================================
+ Hits 31067 31211 +144
- Misses 3102 3552 +450 ☔ View full report in Codecov by Sentry. |
c7b8d4c
into
quadratichq:test-make-cells-async
related to #1447
closes #1409
closes #1114
This pr is meant to explore usage of Atomics and SharedArrayBuffer, for communication between workers.
Using this we can block(sleep) a worker thread and execute synchronously, instead of using async / await
Pros:
'await' outside async function
for functions withcell
in them #1114).Cons:
SharedArrayBuffer
, we need to meet the Security requirements.COOP
,COEP
headers are added invite.config.js
. So everything works without switching to https.quadratic-client
we need to add headers mentioned in Security requirements.