Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preventDefault and stopPropagation should be called before await #1456

Merged

Conversation

AyushAgrawal-A2
Copy link
Collaborator

closes #1453

Changes

  • Moved event.stopPropagation and event.preventDefault before await fn call.
  • Also, I believe it is good practice to call these first before running any internal code. I have moved all occurrences of these to the top of executing code without changing functional logic.

@cla-bot cla-bot bot added the cla-signed label Jun 25, 2024
Copy link

vercel bot commented Jun 25, 2024

@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

@davidfig
Copy link
Collaborator

Please resolve conflict @AyushAgrawal-A2

@AyushAgrawal-A2
Copy link
Collaborator Author

Please resolve conflict @AyushAgrawal-A2

@davidfig
Done

@davidkircos davidkircos merged commit 553e95f into quadratichq:main Jun 27, 2024
8 of 11 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/event-prevent-stop branch June 27, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: keyboard shortcuts don't work on safari
3 participants