feat: Number Formatting #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…q/quadratic into development-number-formatting
split text styling into it's own grouping so as differentiate bold, italic, etc from number formatting
…adratichq/quadratic into development-number-formatting
jimniels
reviewed
Feb 9, 2023
| @@ -143,7 +143,7 @@ export function keyboardCell(options: { | |||
| } | |||
|
|
|||
| // if key is a letter number or space start taking input | |||
There was a problem hiding this comment.
minor: this code comment should probably be more generic so it doesn't fall out of date with the code above it (e.g. "check for special characters to begin taking input")
jimniels
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO