Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline transactions #971

Merged
merged 19 commits into from
Jan 13, 2024
Merged

Offline transactions #971

merged 19 commits into from
Jan 13, 2024

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Jan 9, 2024

Use npm run watch:front-end-no-multiplayer and npm run watch:multiplayer to test offline experience. Turn off the multiplayer, change the grid, and then turn it back on to ensure it's saved to the file.

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Jan 12, 2024 7:22pm

@davidfig davidfig changed the base branch from main to cell-value-code January 9, 2024 19:52
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-971 January 9, 2024 19:53 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-971 January 10, 2024 12:48 Inactive
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (67b0a2d) 89.70% compared to head (7934205) 89.77%.
Report is 1 commits behind head on a-team.

Files Patch % Lines
...re/src/controller/execution/receive_multiplayer.rs 83.33% 17 Missing ⚠️
...roller/active_transactions/unsaved_transactions.rs 85.85% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           a-team     #971      +/-   ##
==========================================
+ Coverage   89.70%   89.77%   +0.07%     
==========================================
  Files         122      124       +2     
  Lines       20639    20972     +333     
==========================================
+ Hits        18514    18828     +314     
- Misses       2125     2144      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-971 January 11, 2024 18:26 Inactive
@davidfig davidfig marked this pull request as ready for review January 11, 2024 18:27
Base automatically changed from cell-value-code to a-team January 12, 2024 11:41
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-971 January 12, 2024 15:12 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-971 January 12, 2024 19:16 Inactive
@davidfig davidfig merged commit 53e838c into a-team Jan 13, 2024
6 of 11 checks passed
@davidfig davidfig deleted the offline-transactions branch January 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants