-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add composable mappings, e.g. use a separate key to jump between snippet tabstops #48
Conversation
smjonas
commented
Dec 7, 2021
•
edited
Loading
edited
- add "actions" users can use to compose their own mappings
- update readme
@mathjiajia could you please test this PR and confirm that everything works as expected? :) |
I noticed an annoying behaviour in the mappings, will fix it |
I'll wait for @mathjiajia before merging, then I will squash |
Dear @smjonas, thanks so much. BTW, if you want to add some explanation in README, below may be better?
|
Thanks for the testing it! I just had another idea how to handle this problem: we could |
Sounds good to me 💪 |
Unrelated: do you guys still see |
it still persists yeah |
But it only happens when nothing is selected, right? Like at the beginning of a line? Edit: it seems to occur when cmp calls Another thing I noticed: are you able to jump when in select mode in a mapping? I thought it should work with |
Thanks to both of you. BTW, |
Btw I didnt't forget about this PR, just thought it was fun to work on treesitter integration for a bit ;) (see #50) |
63620f3
to
0414f2b
Compare
688474c
to
b074963
Compare
…n snippet tabstops Closes quangnguyen30192#45.
b074963
to
266983b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good
Thanks |