Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate outcomes #148

Merged
merged 14 commits into from
Mar 2, 2018
Merged

Fix duplicate outcomes #148

merged 14 commits into from
Mar 2, 2018

Conversation

kuchenrolle
Copy link
Collaborator

Changes proposed in this pull request:

  • outcomes did not get filtered for duplicates with remove_duplicates=True, but they do now. consequently the comparison to the reference file fails, because that one contains duplicate outcomes.
  • re.split() removes the split pattern, so process_context() did not do anything. i removed it and simplified (i think) that part of the code.
  • gen_occurrences() generated an empty occurrence, i changed that by turning the while loop with ifs into a for loop (which is more similar to how "word_to_word" is handled), but alternatively the break condition could just be moved up two lines.
  • handling of "bigrams_to_word" and "trigrams_to_word" only differs in one parameter, so i removed the repetition.
  • i don't understand why the diff shows the temporary_directory, that should be the same in both branches. sorry about that.

@coveralls
Copy link

coveralls commented Mar 1, 2018

Coverage Status

Coverage decreased (-0.06%) to 83.274% when pulling d274a8f on fix-duplicate_outcomes into 9b47606 on master.

Copy link
Member

@derNarr derNarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add test that compares remove_duplicates=True to remove_duplicates=False in preprocess.py

derNarr
derNarr previously approved these changes Mar 2, 2018
@derNarr derNarr merged commit 77678f9 into master Mar 2, 2018
@derNarr derNarr deleted the fix-duplicate_outcomes branch March 2, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants