Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevents macos from automatically installing with openmp extension #178

Merged
merged 2 commits into from
Jan 13, 2020
Merged

prevents macos from automatically installing with openmp extension #178

merged 2 commits into from
Jan 13, 2020

Conversation

Trybnetic
Copy link
Member

This PR introduces separate os-specific install instructions to prevent OSX based systems from trying to install with openmp support.

Fixes #147.

Changes proposed in this pull request:

  • os-specific installation
  • separate .pyx files for openmp and multi-threading implementation

@coveralls
Copy link

coveralls commented Jan 13, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 83.111% when pulling 4cd45a1 on fix-macos into 8bdb7e2 on master.

derNarr
derNarr approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@derNarr derNarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with nearly no code duplication.

@Trybnetic Trybnetic merged commit 01e519b into master Jan 13, 2020
@Trybnetic Trybnetic deleted the fix-macos branch January 13, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derNarr derNarr derNarr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mac os x with clang only
3 participants
@Trybnetic @coveralls @derNarr