BUG use net liquidation value as the denominator in percent allocation calculation #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@humdings does this look ok? |
a-campbell
force-pushed
the
alloc-denom
branch
from
8d596ba
to
1ac5f9e
Compare
|
Waiting for @humdings feedback. Other fix looks good. |
|
@acampbell22 Looks good to me, this will account for the leverage now. |
twiecki
added a commit
that referenced
this pull request
Nov 12, 2015
BUG use net liquidation value as the denominator in percent allocation calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #197