-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for JupyterLab 2 #301
Conversation
- Update the python package coupling to the JupyterLab extension to be less strict, allowing for a coupling to `^1.1.2` instead of exactly `^1.1.1`. This is very relevant if we make a small bump to the extension but don't want to make a new release of qgrid, or if qgrid would be installed by conda and it's availability was delayed so the newer npm package was available but the python package was outdated and coupled to the old versions specifically. - Move various loaders that are only used by webpack to build the json files from being dependencies to being devDependencies. - Bump versions of various dependencies to avoid security issues found in packages by npm.
A good rule of thumb according to this @vidartf. ref: https://discourse.jupyter.org/t/about-jupyter-labextension-link-v-s-install/2201/2?u=consideratio
@gerrymanoim perhaps you could review this? I've worked to debug many extensions lately and feel pretty good about this PR at this point. |
Worth noting i was having problems with qgrid on Jupyter 2.0.1. I can confirm that when I pulled |
I followed somewhat different instructions (npm install fails for some reason) and got this working:
My environment:
|
Ah! |
That would be fantastic if this was merged! |
Hey @consideRatio - apologies for the delay, we've been a bit scattered transitioning to WFH and I missed this. Looking now. |
This looks great, thanks! |
That's out now: Thanks again for the great PR and sorry for the delay on getting this merged. |
In quantopian#301 I forgot to bump this to 1.1.3, which probably is a harmless mistake, but it can be good for anyone in the future to have an easier time making the next release to have this align with the other versions.
In #301 I forgot to bump this to 1.1.3, which probably is a harmless mistake, but it can be good for anyone in the future to have an easier time making the next release to have this align with the other versions.
Hi,
now in with
and with
As I still appear to be getting What am I supposed to be doing? Thanks Graeme |
I just struggled to make qgrid work in Jupyter lab 2.0.1 - what helped me was:
Also check that you have no other qgrid labextensions installed (I've had |
Fixes #299. JupyterLab 2.0.0 is out, and this jupyterlab extension have conflicting dependencies. Note that the failing CI test is related to #300 which is not associated with this PR.
References for JupyterLab extension migration
PR summary
dependencies
to beingdevDependencies
.Try PR
Todo after merge
1.1.3
of the npm package.1.3.1
of the python package. It has been referencing a hardcoded version of the labextension1.1.1
before, so when the1.1.2
was released, that made it fail to accept being used together with it. After this PR, we reference1.1.3
instead.Screenshot