Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Timeseries Caching for Tickers with "/" Char #426

Closed
wants to merge 2 commits into from
Closed

Fixed Timeseries Caching for Tickers with "/" Char #426

wants to merge 2 commits into from

Conversation

cyniphile
Copy link
Contributor

@cyniphile cyniphile mentioned this pull request Nov 3, 2014
Closed
@ssanderson
Copy link
Contributor

Do we need to make a corresponding change on the loading end of this to ensure we load from the right location?

@ssanderson
Copy link
Contributor

Nevermind, just realized this filepath is calculated and passed to both the read and write.

@ssanderson
Copy link
Contributor

We probably have a corresponding bug on Windows if a path contains , might be better to replace '/' with os.path.pathsep.

@twiecki
Copy link
Contributor

twiecki commented Nov 3, 2014

Agreed with @ssanderson that pathsep is the more pythonic option (although no tickers use \).

@twiecki
Copy link
Contributor

twiecki commented Nov 19, 2014

Merged with 1542b41. Thanks!

@twiecki twiecki closed this Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyniphile @ssanderson @twiecki