Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of direct fidelity estimation #2308

Merged
merged 43 commits into from
Oct 29, 2019

Conversation

tonybruguier-google
Copy link
Contributor

Adding an example that illustrates the fidelity estimation, as per these two papers

Direct Fidelity Estimation from Few Pauli Measurements
https://arxiv.org/abs/1104.4695

Practical characterization of quantum devices without tomography
https://arxiv.org/abs/1104.3835

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Oct 10, 2019
@tonybruguier-google tonybruguier-google marked this pull request as ready for review October 10, 2019 15:24
@tonybruguier-google
Copy link
Contributor Author

Happy to withdraw if this is premature.

I've been working with mpharrigan@ but will listen to advice from others, of course.

Copy link
Contributor

@Strilanc Strilanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Let's start with some compactification of the code using things we just recently merged.

examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@tonybruguier-google tonybruguier-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I resolved the comments that I felt I had addressed, but one is blocking.

@tonybruguier-google
Copy link
Contributor Author

I took another look this morning, and I think I can resolve the last comment now.

examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
@tonybruguier-google
Copy link
Contributor Author

Thanks. PTAL.

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coming together, but I have some questions about the implementation, see review comments

examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
examples/fidelity.py Outdated Show resolved Hide resolved
@tonybruguier-google
Copy link
Contributor Author

Thank you both. PTAL.

examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
@tonybruguier-google
Copy link
Contributor Author

All right. I think all the checks are passing now. If I understand correctly, you are the one with write access who can merge changes (if that PR is indeed ready, otherwise happy to work more on it).

Thanks for your patience and all the guidance.

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2019
@CirqBot
Copy link
Collaborator

CirqBot commented Oct 26, 2019

Automerge cancelled: No approved review.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2019
@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2019
@CirqBot
Copy link
Collaborator

CirqBot commented Oct 26, 2019

Automerge cancelled: No approved review.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2019
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving type fixes.

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2019
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 26, 2019
@quantumlib quantumlib deleted a comment from CirqBot Oct 26, 2019
@vtomole
Copy link
Collaborator

vtomole commented Oct 28, 2019

    if not any(review['state'] == 'APPROVED' for review in review_status):
        return CannotAutomergeError('No approved review.')

How!?

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 28, 2019
@CirqBot
Copy link
Collaborator

CirqBot commented Oct 28, 2019

Automerge cancelled: No approved review.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 28, 2019
@Strilanc
Copy link
Contributor

It's because of a pagination issue.

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2019
@CirqBot
Copy link
Collaborator

CirqBot commented Oct 29, 2019

Automerge cancelled: No approved review.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2019
@Strilanc
Copy link
Contributor

(testing)

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 29, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 29, 2019
@CirqBot CirqBot merged commit c7728b9 into quantumlib:master Oct 29, 2019
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 29, 2019
CirqBot pushed a commit that referenced this pull request Oct 29, 2019
- Specify a `per_page` argument of 100 (the maximum) (default was 30)

E.g. this made the difference in #2308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants