-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example of direct fidelity estimation #2308
Conversation
Happy to withdraw if this is premature. I've been working with mpharrigan@ but will listen to advice from others, of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! Let's start with some compactification of the code using things we just recently merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I resolved the comments that I felt I had addressed, but one is blocking.
I took another look this morning, and I think I can resolve the last comment now. |
Thanks. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coming together, but I have some questions about the implementation, see review comments
Thank you both. PTAL. |
All right. I think all the checks are passing now. If I understand correctly, you are the one with write access who can merge changes (if that PR is indeed ready, otherwise happy to work more on it). Thanks for your patience and all the guidance. |
Automerge cancelled: No approved review. |
Automerge cancelled: No approved review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving type fixes.
if not any(review['state'] == 'APPROVED' for review in review_status):
return CannotAutomergeError('No approved review.') How!? |
Automerge cancelled: No approved review. |
It's because of a pagination issue. |
Automerge cancelled: No approved review. |
(testing) |
- Specify a `per_page` argument of 100 (the maximum) (default was 30) E.g. this made the difference in #2308
Adding an example that illustrates the fidelity estimation, as per these two papers
Direct Fidelity Estimation from Few Pauli Measurements
https://arxiv.org/abs/1104.4695
Practical characterization of quantum devices without tomography
https://arxiv.org/abs/1104.3835