Skip to content

Commit

Permalink
Revert "Switch to using the incremental pylint. Turn on documentation…
Browse files Browse the repository at this point in the history
… linters. (#4267)" (#4306)

This reverts commit 52aba59.
  • Loading branch information
balopat committed Jul 9, 2021
1 parent 52aba59 commit b1a35bf
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 94 deletions.
17 changes: 0 additions & 17 deletions .github/workflows/ci.yml
Expand Up @@ -102,23 +102,6 @@ jobs:
run: check/pylint --version
- name: Lint
run: check/pylint -v
incremental_lint:
name: Incremental Lint check
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: actions/setup-python@v1
with:
python-version: '3.8'
architecture: 'x64'
- name: Install pylint
run: pip install -r dev_tools/requirements/deps/pylint.txt
- name: Display version
run: check/pylint --version
- name: Lint
run: check/pylint-changed-files
doc_test:
name: Doc test
runs-on: ubuntu-20.04
Expand Down
2 changes: 1 addition & 1 deletion check/pylint-changed-files
Expand Up @@ -64,5 +64,5 @@ echo "Found ${num_changed} lintable files associated with changes." >&2
if [ "${num_changed}" -eq 0 ]; then
exit 0
fi
pylint --rcfile=dev_tools/conf/incremental.pylintrc ${changed[@]}
pylint --rcfile=dev_tools/conf/.pylintrc ${changed[@]}

2 changes: 1 addition & 1 deletion dev_tools/bash_scripts_test.py
Expand Up @@ -617,7 +617,7 @@ def test_pylint_changed_files_file_selection(tmpdir_factory):
).split()
)

intercepted_prefix = 'INTERCEPTED pylint --rcfile=dev_tools/conf/incremental.pylintrc '
intercepted_prefix = 'INTERCEPTED pylint --rcfile=dev_tools/conf/.pylintrc '

result = run(
script_file='check/pylint-changed-files',
Expand Down
75 changes: 0 additions & 75 deletions dev_tools/conf/incremental.pylintrc

This file was deleted.

0 comments on commit b1a35bf

Please sign in to comment.