Revert "Switch to using the incremental pylint. Turn on documentation linters." #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viathor
approved these changes
Jul 9, 2021
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
… linters. (quantumlib#4267)" (quantumlib#4306) This reverts commit 52aba59.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4267
I would like to come up with a different strategy that doesn't involve increasing the scope of every single change we do. Either by filtering only on lines changed, or by adding pylint disable comments on all the existing bad docstrings.
See this change for example, where the contributor now would have to be forced to fix 10+ docstrings unrelated to his change: https://github.com/quantumlib/Cirq/pull/4282/checks?check_run_id=3032227369