Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Simplify dev_tools.notebooks.utils.rewrite_notebook (#6030)
* Simplify dev_tools.notebooks.utils.rewrite_notebook - Do not return the OS file descriptor, it was only used to close the file in rewrite_notebook callers - Return only the filename of the rewritten notebook - Always create a temporary file, even if identical to the input notebook, so it can be safely removed after a test - Clean up temporary files produced by rewrite_notebook in the tests
- Loading branch information
1 parent
8b97aa5
commit f636c5f
Showing
4 changed files
with
35 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters