Fix special new line characters in a file #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6a54c65.
tonybruguier-google
changed the title
|
Actually, I looked more and the character is ASCII 0x0A a.k.a. LN a.k.a. line-feed. |
|
My IDE does indeed report that the file uses CRLF (windows-style) line endings. The convention is LF (unix-style) line endings |
cduck
approved these changes
Jan 27, 2020
|
@cduck Should we add that command as part of |
|
@vtomole That might be a good idea although this issue doesn't occur often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this file had weird unicode characters for new lines. Maybe it would make sense to fix them?
Fixes #2036.