Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return values to direct_fidelity_estimation() #2889

Merged
merged 24 commits into from
Apr 10, 2020
Merged

Add return values to direct_fidelity_estimation() #2889

merged 24 commits into from
Apr 10, 2020

Conversation

tonybruguier-google
Copy link
Contributor

The intent is to eventually run experiments on a real computer, and thus, it might make sense to record intermediate data for later analysis

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Apr 3, 2020
viathor
viathor reviewed Apr 6, 2020
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use-case for the "run log"?

@tonybruguier-google
Copy link
Contributor Author

Hi,

I would like to eventually run experiments, and so I was advised by mpharrigan@ to record everything since compute time is expensive. I have a quick example of how I would use it here:
https://github.com/tonybruguier-google/Cirq/blob/d3ea3159880359b179b18688f0708022ce948b8a/examples/direct_fidelity_estimation_recirq.py#L52

@tonybruguier-google
Copy link
Contributor Author

Thanks. PTAL.

viathor
viathor reviewed Apr 8, 2020
View reviewed changes
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
@tonybruguier-google
Copy link
Contributor Author

Thanks. PTAL.

@tonybruguier-google
Copy link
Contributor Author

PTAL.

viathor
viathor reviewed Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only minor comments left.

examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation_test.py Show resolved Hide resolved
@tonybruguier-google
Copy link
Contributor Author

Thanks. PTAL.

viathor
viathor reviewed Apr 8, 2020
View reviewed changes
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, one comment about comment.

examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.py Outdated Show resolved Hide resolved
@tonybruguier-google
Copy link
Contributor Author

Thanks. PTAL.

@viathor
Copy link
Collaborator

viathor commented Apr 8, 2020

Thank you for all the additional cleanup you have done in this PR! It is really nice.

@tonybruguier-google
Copy link
Contributor Author

Thanks for your patience with me and making me a better coder.

@viathor viathor merged commit 11b1433 into quantumlib:master Apr 10, 2020
@tonybruguier-google tonybruguier-google deleted the run_exps branch April 10, 2020 16:44
tanujkhattar pushed a commit to tanujkhattar/Cirq that referenced this pull request Apr 20, 2020
@tonybruguier-google @tanujkhattar
Add return values to direct_fidelity_estimation() (quantumlib#2889)
44afb7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan left review comments

@viathor viathor viathor approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tonybruguier-google @viathor @mpharrigan @googlebot @tonybruguier @CirqBot