Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a DFE Jupyter notebook #2932

Merged
merged 36 commits into from
Jul 27, 2020
Merged

Conversation

tonybruguier-google
Copy link
Contributor

As requested, I added a Jupyter notebook that showcases the DFE code.

Note that the present version relies on under-review PR:
#2918

I've never gone through a review for a notebook, so I am attaching a PDF of what it currently looks like.
direct_fidelity_estimation.pdf

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Apr 22, 2020
@tonybruguier-google tonybruguier-google marked this pull request as ready for review April 22, 2020 17:41
@tonybruguier-google
Copy link
Contributor Author

Friendly ping on this PR.

I think @mpharrigan has the most context, but feedback from anyone is, of course, welcome.

@mpharrigan mpharrigan self-requested a review May 5, 2020 06:41
@tonybruguier-google
Copy link
Contributor Author

Hi Matt,

Do you have any comment on this PR? It's only a Jupyter notebook.

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of nits, but this reads really well. I love the pedagogy of showing the top-level function doing the whole thing and then a deeper dive into the technical aspects

examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
examples/direct_fidelity_estimation.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I think we need to figure out how to make our notebooks more portable (e.g. openable and runnable in Colab easily). But that can be done independently of this PR.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 27, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 27, 2020
@CirqBot
Copy link
Collaborator

CirqBot commented Jul 27, 2020

Automerge cancelled: A required status check is not present.

Missing statuses: ['cla/google']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 27, 2020
@balopat
Copy link
Contributor

balopat commented Jul 27, 2020

@googlebot please rescan

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 27, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 27, 2020
@CirqBot CirqBot merged commit f3acfbd into quantumlib:master Jul 27, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 27, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
As requested, I added a Jupyter notebook that showcases the DFE code.

Note that the present version relies on under-review PR:
quantumlib#2918

I've never gone through a review for a notebook, so I am attaching a PDF of what it currently looks like.
[direct_fidelity_estimation.pdf](https://github.com/quantumlib/Cirq/files/4517980/direct_fidelity_estimation.pdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants