-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a DFE Jupyter notebook #2932
Conversation
…q into exhaust_clifford
Friendly ping on this PR. I think @mpharrigan has the most context, but feedback from anyone is, of course, welcome. |
Hi Matt, Do you have any comment on this PR? It's only a Jupyter notebook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of nits, but this reads really well. I love the pedagogy of showing the top-level function doing the whole thing and then a deeper dive into the technical aspects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I think we need to figure out how to make our notebooks more portable (e.g. openable and runnable in Colab easily). But that can be done independently of this PR.
Automerge cancelled: A required status check is not present. Missing statuses: ['cla/google'] |
@googlebot please rescan |
As requested, I added a Jupyter notebook that showcases the DFE code. Note that the present version relies on under-review PR: quantumlib#2918 I've never gone through a review for a notebook, so I am attaching a PDF of what it currently looks like. [direct_fidelity_estimation.pdf](https://github.com/quantumlib/Cirq/files/4517980/direct_fidelity_estimation.pdf)
As requested, I added a Jupyter notebook that showcases the DFE code.
Note that the present version relies on under-review PR:
#2918
I've never gone through a review for a notebook, so I am attaching a PDF of what it currently looks like.
direct_fidelity_estimation.pdf