Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize measurement_key to measurement_keys protocol #2944

Merged
merged 7 commits into from
May 17, 2020
Merged

Generalize measurement_key to measurement_keys protocol #2944

merged 7 commits into from
May 17, 2020

Conversation

Strilanc
Copy link
Contributor

@Strilanc Strilanc commented Apr 28, 2020 •
edited

  • This is necessary for eventually allowing measurements inside of composite operations and other kinds of more general measurements

@Strilanc
Generalize measurement_key to measurement_keys protocol
0d6265f 
- This is necessary for allowing measurements inside of composite operations
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Apr 28, 2020
viathor
viathor reviewed Apr 28, 2020
View reviewed changes
cirq/ops/gate_operation.py Outdated Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Outdated Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Outdated Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Outdated Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Outdated Show resolved Hide resolved
cirq/protocols/measurement_key_protocol.py Show resolved Hide resolved
@Strilanc Strilanc mentioned this pull request Apr 29, 2020
Closed
@Strilanc Strilanc assigned viathor and Strilanc and unassigned viathor and Strilanc Apr 29, 2020
@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 17, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 17, 2020
@CirqBot CirqBot merged commit 5c76c2c into master May 17, 2020
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 17, 2020
@CirqBot CirqBot deleted the measure_decompose3 branch May 17, 2020 23:40
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 17, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@Strilanc
Generalize measurement_key to measurement_keys protocol (quantuml…
69a2590 
…ib#2944)

- This is necessary for eventually allowing measurements inside of composite operations and other kinds of more general measurements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viathor viathor viathor approved these changes

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Strilanc @viathor @googlebot @CirqBot