Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the release procedure to the markdown file in cirq #2992

Merged
merged 4 commits into from
May 13, 2020

Conversation

dstrain115
Copy link
Collaborator

  • Adds the new release procedure to markdown in cirq.

- Adds the new release procedure to markdown in cirq.
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label May 11, 2020
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

release.md Outdated
themselves are created. Note that development is done on the `master`
branch, so if you want to use a more stable version you should use one
of the [releases](https://github.com/quantumlib/Cirq/releases) or
install from pypi using `pip install cirq`. Nightly releases can be
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Nightly isn't quite correct word since it is per merge to master. "Release from the latest commit to master"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, I didn't realize that. Has this changed over the last few months?


```bash
git checkout master -b "v${VER}-dev"
vi _version.py # Remove .dev from version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or emacs ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using emacs would be incorrect, just ask the internet for a uniformly consistent opinion.

release.md Outdated

### Create distribution wheel

From release branch, create a binary distribution wheel. This is the package that will go to pypi.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: line wrap this closer to rest of file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dstrain115 dstrain115 merged commit c7a8c19 into quantumlib:master May 13, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
* Add the release procedure to the markdown file in cirq

- Adds the new release procedure to markdown in cirq.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants