-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disentangle MS gate and XXPowGate. #3015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me with two minor comments. Feels good to remove special cases from XXPow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry should have marked request changes.
Resolved the comments. PTAL. |
* Add separate MSGate and distangle from XXPowGate * Revert accidental deletion of quil related changes. * Fix formatting changes and add tests for coverage * Add equality group test and resolved comments Co-authored-by: Dave Bacon <dabacon@gmail.com>
To fix #2958