Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle MS gate and XXPowGate. #3015

Merged
merged 10 commits into from
Jun 7, 2020
Merged

Conversation

tanujkhattar
Copy link
Collaborator

To fix #2958

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label May 17, 2020
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me with two minor comments. Feels good to remove special cases from XXPow.

cirq/ion/ion_gates_test.py Outdated Show resolved Hide resolved
cirq/ion/ion_gates_test.py Show resolved Hide resolved
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry should have marked request changes.

@tanujkhattar tanujkhattar requested a review from dabacon May 20, 2020 16:00
@tanujkhattar
Copy link
Collaborator Author

Resolved the comments. PTAL.

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 4, 2020
@vtomole vtomole merged commit 03a7dc8 into quantumlib:master Jun 7, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
* Add separate MSGate and distangle from XXPowGate

* Revert accidental deletion of quil related changes.

* Fix formatting changes and add tests for coverage

* Add equality group test and resolved comments

Co-authored-by: Dave Bacon <dabacon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Tells CirqBot to sync and merge this PR. (If it's running.) cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mølmer–Sørensen gate should be disentangled from XX parity gate
4 participants