Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _mixture_ support to Controlled{Operation,Gate} #3042

Merged
merged 4 commits into from
May 27, 2020
Merged

Add _mixture_ support to Controlled{Operation,Gate} #3042

merged 4 commits into from
May 27, 2020

Conversation

Strilanc
Copy link
Contributor

No description provided.

@Strilanc Strilanc requested a review from dabacon May 27, 2020 02:30
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label May 27, 2020
dabacon
dabacon approved these changes May 27, 2020
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really not a fan of ControlledOperation. (And a gate that delegates to an operation feels incredibly backwards to me)

cirq/ops/controlled_operation.py Outdated
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
from typing import (Any, cast, Collection, Dict, Optional, Sequence, Tuple,
Union, TYPE_CHECKING)
Union, TYPE_CHECKING, List)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: abc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged. I think if we want to enforce sorted imports we should use a tool to automate it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. https://github.com/timothycrosley/isort

@Strilanc Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 27, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 27, 2020
@CirqBot CirqBot merged commit 79d83e0 into master May 27, 2020
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label May 27, 2020
@CirqBot CirqBot deleted the controlled_mixture branch May 27, 2020 22:00
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label May 27, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@Strilanc
Add _mixture_ support to Controlled{Operation,Gate} (quantumlib#3042)
9d0ba73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Strilanc @dabacon @googlebot @CirqBot