Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hidden Shift Algorithm example #3052

Merged
merged 9 commits into from
Jul 23, 2020
Merged

Add Hidden Shift Algorithm example #3052

merged 9 commits into from
Jul 23, 2020

Conversation

sebgrijalva
Copy link
Contributor

(This was originally opened in #3035 but there was a contributor conflict)

I'm adding an example of the Hidden Shift Algorithm, requested in #2252

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label May 30, 2020
vtomole
vtomole requested changes May 30, 2020
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this example in examples_test.py to pass the coverage check.

@sebgrijalva sebgrijalva requested a review from vtomole May 30, 2020 18:54
vtomole
vtomole requested changes May 30, 2020
View reviewed changes
examples/hidden_shift_algorithm.py Outdated Show resolved Hide resolved
examples/hidden_shift_algorithm.py Show resolved Hide resolved
examples/hidden_shift_algorithm.py Show resolved Hide resolved
@sebgrijalva sebgrijalva mentioned this pull request May 31, 2020
Closed
@sebgrijalva sebgrijalva requested a review from vtomole July 10, 2020 19:17
@mickyabir
Copy link

What's the status of this pr? @sebgrijalva

@sebgrijalva
Copy link
Contributor Author

What's the status of this pr? @sebgrijalva

It's been improved after commentaries by @vtomole , and it's ready for review + merge.

vtomole
vtomole requested changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took a while. This looks good barring some minor suggestions.

examples/hidden_shift_algorithm.py Outdated Show resolved Hide resolved
examples/hidden_shift_algorithm.py Outdated Show resolved Hide resolved
examples/hidden_shift_algorithm.py Outdated Show resolved Hide resolved
examples/hidden_shift_algorithm.py Show resolved Hide resolved
examples/hidden_shift_algorithm.py Outdated Show resolved Hide resolved
examples/hidden_shift_algorithm.py Outdated Show resolved Hide resolved
vtomole
vtomole approved these changes Jul 23, 2020
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sebgrijalva Thanks!

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 23, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 23, 2020
@CirqBot CirqBot merged commit 3577ea2 into quantumlib:master Jul 23, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 23, 2020
@sebgrijalva sebgrijalva deleted the hidden_shift_example branch July 23, 2020 21:02
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@sebgrijalva
Add Hidden Shift Algorithm example (quantumlib#3052)
d6bbc49 
(This was originally opened in quantumlib#3035 but there was a contributor conflict)

I'm adding an example of the Hidden Shift Algorithm, requested in quantumlib#2252
@balopat balopat mentioned this pull request Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sebgrijalva @mickyabir @vtomole @googlebot @CirqBot