-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakes in random_circuit_test #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3083 |
dstrain115
approved these changes
Jun 10, 2020
MichaelBroughton
added a commit
that referenced
this pull request
Jun 12, 2020
* [SVG] Noise hack and font fix (#3076) - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size - Don't display virtual tags (for noise) xref #2905 * Support multi-qubit measurement in plot_state_histogram (#3054) * Add generated code for batch.proto (#3086) Review: @dstrain115 * Fix flakes in random_circuit_test (#3084) * Added api docs gen (copy from TFQ). * updated site_path prefix. * removed pre-built. * rename. * move to dev_tools. * removed __future__ and formatting. * yet more formatting. Co-authored-by: Matthew Harrigan <mpharrigan@google.com> Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com> Co-authored-by: Matthew Neeley <maffoo@google.com> Co-authored-by: Dave Bacon <dabacon@gmail.com>
MichaelBroughton
added a commit
that referenced
this pull request
Jun 12, 2020
* [SVG] Noise hack and font fix (#3076) - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size - Don't display virtual tags (for noise) xref #2905 * Support multi-qubit measurement in plot_state_histogram (#3054) * Add generated code for batch.proto (#3086) Review: @dstrain115 * Fix flakes in random_circuit_test (#3084) * Fix Quirk import extra gates bug * Move image files to docs/images/ * Move unneeded site assets * Move Sphinx templates, Makefile, conf, and init * Added api docs gen (copy from TFQ). (#3089) * [SVG] Noise hack and font fix (#3076) - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size - Don't display virtual tags (for noise) xref #2905 * Support multi-qubit measurement in plot_state_histogram (#3054) * Add generated code for batch.proto (#3086) Review: @dstrain115 * Fix flakes in random_circuit_test (#3084) * Added api docs gen (copy from TFQ). * updated site_path prefix. * removed pre-built. * rename. * move to dev_tools. * removed __future__ and formatting. * yet more formatting. Co-authored-by: Matthew Harrigan <mpharrigan@google.com> Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com> Co-authored-by: Matthew Neeley <maffoo@google.com> Co-authored-by: Dave Bacon <dabacon@gmail.com> * Move doc tools to /dev_tools/docs/ * Move examples index into tutorials/ * Move basics tutorial into tutorials/ * Encode URL bracket so not mistaken for template. * Update references to moves docs and image files. * Update references to docs_coverage_test.py * Format py with check/format-incremental --apply * Move Sphinx RST files * Add _index.yaml for site * Add initial _book.yaml for leftnav * Manually format docs/_sphinx/conf.py for CI * Update references to moved api.rst file * Move docs/_sphinx to dev_tools/docs/sphinx * Update README.rst path for snippets_test.py * Move run_doctest to dev_tools/docs/ * Move build-docs.sh to dev_tools/docs/sphinx/ * Update references to build-docs.sh * Remove build_docs CI test Co-authored-by: Matthew Harrigan <mpharrigan@google.com> Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com> Co-authored-by: Matthew Neeley <maffoo@google.com> Co-authored-by: Dave Bacon <dabacon@gmail.com> Co-authored-by: Matteo Pompili <matpompili@gmail.com> Co-authored-by: MichaelBroughton <MichaelBroughton@users.noreply.github.com>
balopat
pushed a commit
to balopat/Cirq
that referenced
this pull request
Aug 18, 2020
* [SVG] Noise hack and font fix (quantumlib#3076) - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size - Don't display virtual tags (for noise) xref quantumlib#2905 * Support multi-qubit measurement in plot_state_histogram (quantumlib#3054) * Add generated code for batch.proto (quantumlib#3086) Review: @dstrain115 * Fix flakes in random_circuit_test (quantumlib#3084) * Added api docs gen (copy from TFQ). * updated site_path prefix. * removed pre-built. * rename. * move to dev_tools. * removed __future__ and formatting. * yet more formatting. Co-authored-by: Matthew Harrigan <mpharrigan@google.com> Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com> Co-authored-by: Matthew Neeley <maffoo@google.com> Co-authored-by: Dave Bacon <dabacon@gmail.com>
balopat
pushed a commit
to balopat/Cirq
that referenced
this pull request
Aug 18, 2020
* [SVG] Noise hack and font fix (quantumlib#3076) - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size - Don't display virtual tags (for noise) xref quantumlib#2905 * Support multi-qubit measurement in plot_state_histogram (quantumlib#3054) * Add generated code for batch.proto (quantumlib#3086) Review: @dstrain115 * Fix flakes in random_circuit_test (quantumlib#3084) * Fix Quirk import extra gates bug * Move image files to docs/images/ * Move unneeded site assets * Move Sphinx templates, Makefile, conf, and init * Added api docs gen (copy from TFQ). (quantumlib#3089) * [SVG] Noise hack and font fix (quantumlib#3076) - Specify the font. This should not be a change for viewing in Jupyter notebook but fixes opening the svg data in e.g. inkscape where the default font is different and the boxes aren't the right size - Don't display virtual tags (for noise) xref quantumlib#2905 * Support multi-qubit measurement in plot_state_histogram (quantumlib#3054) * Add generated code for batch.proto (quantumlib#3086) Review: @dstrain115 * Fix flakes in random_circuit_test (quantumlib#3084) * Added api docs gen (copy from TFQ). * updated site_path prefix. * removed pre-built. * rename. * move to dev_tools. * removed __future__ and formatting. * yet more formatting. Co-authored-by: Matthew Harrigan <mpharrigan@google.com> Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com> Co-authored-by: Matthew Neeley <maffoo@google.com> Co-authored-by: Dave Bacon <dabacon@gmail.com> * Move doc tools to /dev_tools/docs/ * Move examples index into tutorials/ * Move basics tutorial into tutorials/ * Encode URL bracket so not mistaken for template. * Update references to moves docs and image files. * Update references to docs_coverage_test.py * Format py with check/format-incremental --apply * Move Sphinx RST files * Add _index.yaml for site * Add initial _book.yaml for leftnav * Manually format docs/_sphinx/conf.py for CI * Update references to moved api.rst file * Move docs/_sphinx to dev_tools/docs/sphinx * Update README.rst path for snippets_test.py * Move run_doctest to dev_tools/docs/ * Move build-docs.sh to dev_tools/docs/sphinx/ * Update references to build-docs.sh * Remove build_docs CI test Co-authored-by: Matthew Harrigan <mpharrigan@google.com> Co-authored-by: Animesh Sinha <AnimeshSinha1309@gmail.com> Co-authored-by: Matthew Neeley <maffoo@google.com> Co-authored-by: Dave Bacon <dabacon@gmail.com> Co-authored-by: Matteo Pompili <matpompili@gmail.com> Co-authored-by: MichaelBroughton <MichaelBroughton@users.noreply.github.com>
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes test data (about 1 in 100) had no gates that act on few enough qubits to fit with number of qubits.
f
in error and improves test case for that error.