Defensively copy density matrices in simulator #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cduck
reviewed
Jun 25, 2020
95-martin-orion
requested changes
Jun 25, 2020
95-martin-orion
approved these changes
Jun 25, 2020
cduck
reviewed
Jun 25, 2020
cduck
requested changes
Jun 25, 2020
cduck
approved these changes
Jun 25, 2020
| @@ -1134,6 +1136,8 @@ def test_density_matrix_copy(): | |||
| traces.append(np.trace(step.density_matrix(copy=False))) | |||
| assert any(not np.isclose(np.trace(x), 1.0) for x in matrices) | |||
| assert all(np.isclose(x, 1.0) for x in traces) | |||
| assert any(not np.shares_memory(x, y) for x, y in | |||
There was a problem hiding this comment.
You mean all(not or not any(?
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['cla/google'] |
CirqBot
removed
automerge
cduck
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['cla/google'] |
CirqBot
removed
automerge
|
@clabot this should be fine |
tai271828
pushed a commit
to tai271828/Cirq
that referenced
this pull request
Jun 26, 2020
tai271828
pushed a commit
to tai271828/Cirq
that referenced
this pull request
Jun 27, 2020
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
CirqBot
pushed a commit
that referenced
this pull request
Jan 12, 2021
During the (ongoing) review of #3630 95-martin-orion@ found a bug in my draft code. He said that I should copy state like in #3109. I changed my code and added a test in that PR. However, I had inspired myself from the Clifford code which could have the same issue (I think), and so I am fixing the code in the present PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that by default when you access the density matrix during simulation, it makes a copy of the matrix. This can be overridden if one wants to get the speed benefits of not copying.