Add KakDecomposition._decompose_ by fixing factor of 2 error in exp(PauliString) #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Strilanc
commented
Jul 7, 2020
Strilanc
commented
- I compared against results from WolframAlpha to make sure the modified tests are now correct
…auliString) - I compared against results from WolframAlpha to make sure the modified tests are now correct
viathor
approved these changes
Jul 8, 2020
| u = cirq.unitary(np.exp(-1j * np.pi / 4 * cirq.Z(a) * cirq.Z(b))) | ||
| cirq.testing.assert_allclose_up_to_global_phase(u, | ||
| np.diag([1, 1j, 1j, 1]), | ||
| atol=1e-8) |
There was a problem hiding this comment.
Stronger assertion:
cirq.testing. assert_allclose(u, np.diag(np.sqrt(-1j), np.sqrt(1j), np.sqrt(1j), np.sqrt(-1j)), atol=1e-8)There was a problem hiding this comment.
I intentionally only did it up to global phase to make the test simpler to write, to make sure the complications weren't hiding a mistake.
|
|
||
|
|
||
| @pytest.mark.parametrize('unitary', [ | ||
| cirq.testing.random_unitary(4), |
There was a problem hiding this comment.
Optional: I wonder what distribution we get here on the elements of KAK (e.g. on the three interaction coefficients). A good addition to the random unitary test would be one synthesized from known coefficients, e.g.
u = np.exp(1j*np.pi*(0.2*cirq.unitary(cirq.XX) + 0.3*cirq.unitary(cirq.YY) + 0.4*cirq.unitary(cirq.ZZ)))There was a problem hiding this comment.
I added a couple more cases. The "arbitrary fixed coefficients" case is very well covered by the random unitary; the corner cases have to do with interaction coefficients being zero or maxed.
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
…auliString) (quantumlib#3125) - I compared against results from WolframAlpha to make sure the modified tests are now correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.