Use device instead of gateset validation in ZerosSampler #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstrain115
reviewed
Jul 16, 2020
| all gates in the circuit are from the given gate set. | ||
| """ | ||
| self.gate_set = gate_set | ||
|
|
||
| def run_sweep( |
There was a problem hiding this comment.
I am fine with getting rid of validation altogether, but one alternative I just thought of was to add an optional device parameter. That could also validate the circuit in a more natural way.
There was a problem hiding this comment.
OK added device validation. Could also just do this by adding it to a circuit.
dabacon
changed the title
balopat
approved these changes
Jul 20, 2020
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
…3142) This introduces a dependency of cirq on cirq.google, which we want to avoid. If we want a gate set validating version of this we should put it in cirq.google.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a dependency of cirq on cirq.google, which we want to avoid. If we want a gate set validating version of this we should put it in cirq.google.