Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove q from calibrations.py #3163

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Conversation

dstrain115
Copy link
Collaborator

- Qubits from engine have not had the 'q' prefix
in a while.  Removing this prefix check from the
calibration code.

- Fixes quantumlib#2963
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 22, 2020
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some broken tests.

@dabacon
Copy link
Collaborator

dabacon commented Jul 22, 2020

Also I cannot resist. "There is no q in calibrations".

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 22, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 22, 2020
@balopat balopat dismissed dabacon’s stale review July 22, 2020 18:54

tests are fixed

@CirqBot CirqBot merged commit 0952958 into quantumlib:master Jul 22, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 22, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
- Qubits from engine have not had the 'q' prefix
in a while.  Removing this prefix check from the
calibration code.

- Fixes quantumlib#2963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update code for when Engine metric qubits are formatted differently
5 participants