Test the right order finder #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
approved these changes
Jul 22, 2020
viathor
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Aug 23, 2020
Just noticed that `test_example_shor_find_factor_with_composite_n_and_quantum_order_finder` actually tests the naive order finder instead of testing the quantum order finder. Note that the naive order finder is already tested by `test_example_shor_find_factor_with_composite_n_and_naive_order_finder`. Looks like a copy-paste error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that
test_example_shor_find_factor_with_composite_n_and_quantum_order_finderactually tests the naive order finder instead of testing the quantum order finder.Note that the naive order finder is already tested by
test_example_shor_find_factor_with_composite_n_and_naive_order_finder. Looks like a copy-paste error.