Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding rstcheck for rst files #3177

Merged
merged 2 commits into from
Jul 25, 2020
Merged

adding rstcheck for rst files #3177

merged 2 commits into from
Jul 25, 2020

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jul 24, 2020 •
edited

Adds rstcheck to the doc tests CI step.

This is to avoid accidentally breaking pypi publishing with syntactically incorrect RST files. See #3175 for when this happened.

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 24, 2020
@balopat balopat requested a review from maffoo July 24, 2020 17:19
maffoo
maffoo approved these changes Jul 25, 2020
View reviewed changes
Copy link
Contributor

@maffoo maffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning the rstcheck version. Otherwise LGTM.

dev_tools/conf/pip-list-dev-tools.txt Outdated Show resolved Hide resolved
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 25, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 25, 2020
@CirqBot CirqBot merged commit c5584c0 into quantumlib:master Jul 25, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 25, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
@balopat
adding rstcheck for rst files (quantumlib#3177)
f7f8108 
Adds rstcheck to the doc tests CI step.

This is to avoid accidentally breaking pypi publishing with syntactically incorrect. See quantumlib#3175 for when this happened.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maffoo maffoo maffoo approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balopat @maffoo @googlebot @CirqBot