Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pasqal documentation #3193

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Conversation

HGSilveri
Copy link
Collaborator

  • Documents detailing the usage of Pasqal's devices and sampler
  • A "getting_started" tutorial in the form of a Jupyter notebook

@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Aug 5, 2020
@HGSilveri
Copy link
Collaborator Author

Hi again @balopat ! As promised, here are the docs.

As before, the CI error comes from the fact that they are not included in any toctree. I don't want to make decisions on that by myself, so please let me know how you would have me integrate them.

@balopat
Copy link
Contributor

balopat commented Aug 6, 2020

Hi again @balopat ! As promised, here are the docs.

As before, the CI error comes from the fact that they are not included in any toctree. I don't want to make decisions on that by myself, so please let me know how you would have me integrate them.

Thank you! The docs are looking good, love the PNGs ;) I'm going to get a consensus on the placement, but I think you should have first class entry similar to the "Google Documentation" header, between Google and Developer documentation would be the "Pasqal Documentation".

@balopat
Copy link
Contributor

balopat commented Aug 6, 2020

@HGSilveri please go ahead and add "Pasqal documentation" in the main index.rst between Google Documentation and Developer Documentation.

@HGSilveri
Copy link
Collaborator Author

Great news, @balopat ! It's done. I also shortened the title of the tutorial, I figured it might have been too long for the menu.

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 7, 2020
@CirqBot
Copy link
Collaborator

CirqBot commented Aug 7, 2020

Automerge cancelled: No approved review.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 7, 2020
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 7, 2020
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 7, 2020
@CirqBot CirqBot merged commit 4539bb9 into quantumlib:master Aug 7, 2020
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 7, 2020
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this pull request Aug 23, 2020
- Documents detailing the usage of Pasqal's devices and sampler
- A "getting_started" tutorial in the form of a Jupyter notebook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants