Change type signature of cirq.resolve_parameters to preserve types #3922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
approved these changes
Mar 17, 2021
balopat
added
the
automerge
CirqBot
pushed a commit
that referenced
this pull request
Mar 18, 2021
Follow-up to #3922. Clean up `_resolve_parameters_` method signatures by adding types where appropriate and using consistent argument names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3390
Only had to modify a couple of places where mypy complained about types in
DiagonalGateandTwoQubitDiagonalGate, which acceptedListbut stored a tuple internally. Also had to add a couple of casts inresolve_parameters, but I've tried to document what's going on there.