Clean up _resolve_parameters_ method signatures #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add types where appropriate and use consistent argument names
95-martin-orion
approved these changes
Mar 18, 2021
cirq/ops/eigen_gate.py
Outdated
| return self._with_exponent(exponent=param_resolver.value_of(self._exponent, recursive)) | ||
| def _resolve_parameters_( | ||
| self: TSelf, resolver: 'cirq.ParamResolver', recursive: bool | ||
| ) -> 'EigenGate': |
There was a problem hiding this comment.
Should this be TSelf instead of EigenGate, to match self?
There was a problem hiding this comment.
I tried that, but it doesn't work because self._with_exponent does not return TSelf. If you change that also, there are problems with eigengate subclasses like _PauliX since those can return a different type when the exponent is changed (e.g. a generic XPowGate in stead of _PauliX). I think we'll have to live with the less specific types here. I did remove the TSelf annotation here since it wasn't doing anything.
maffoo
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3922. Clean up
_resolve_parameters_method signatures by adding types where appropriate and using consistent argument names.