Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation in docs #3974

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Fix indentation in docs #3974

merged 2 commits into from
Apr 28, 2021

Conversation

unaiic
Copy link
Contributor

@unaiic unaiic commented Mar 27, 2021

Changes notebooks which used 2 or 3 spaces as indentation. Python and Cirq use 4 instead, thus the level of indentation is made consistent.

Fixes #3729.

@unaiic unaiic requested review from cduck, vtomole, wcourtney and a team as code owners March 27, 2021 14:34
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Mar 27, 2021
@vtomole
Copy link
Collaborator

vtomole commented Mar 28, 2021

Is it possible to added a format checker like Jupyter-black. I've filed #3976

@95-martin-orion
Copy link
Collaborator

@unaiic and @vtomole: do the changes linked in #3976 make this obsolete? If so, we should close this PR.

@unaiic unaiic closed this Apr 27, 2021
@vtomole
Copy link
Collaborator

vtomole commented Apr 27, 2021

@95-martin-orion This notification slipped by me. Yes, we can close.

@mpharrigan
Copy link
Collaborator

Can we merge this anyway? #4020 is taking a while and this PR is a clear improvement over the status quo.

@mpharrigan mpharrigan reopened this Apr 28, 2021
@vtomole
Copy link
Collaborator

vtomole commented Apr 28, 2021

@mpharrigan I Agree.

@mpharrigan
Copy link
Collaborator

sweet thanks

@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 28, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 28, 2021
@CirqBot CirqBot merged commit d448a35 into quantumlib:master Apr 28, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 28, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Changes notebooks which used 2 or 3 spaces as indentation. Python and Cirq use 4 instead, thus the level of indentation is made consistent.

Fixes quantumlib#3729.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent level of indentation in some notebooks
5 participants